Fix issues related to URL handling
Reported by Simon Rozet | February 5th, 2009 @ 09:56 PM
cf. issue raised on the ML: Integrity with a prefix?
The map "/integrity" do; run ...; end has the same effect that my prefix in thin.yml : the prefixed url reach sinatra, but the links are bad.
In fact, if we want integrity to run with prefix, we'll have to rewrite every link with a little helper, as for any Sinatra app :(
Also, the base_url config option shouldn't be
needed
Comments and changes to this ticket
-
Simon Rozet February 14th, 2009 @ 04:11 PM
- State changed from “new” to “open”
http://github.com/Arthur/integrity/commit/a36188865ce37cad7eb1d20c638ceaeab611718f has a fix but is lacking test
-
Simon Rozet February 22nd, 2009 @ 10:20 PM
I gave this a shoot and it seems to be working. But we need to patch Webrat if we want to test this.
-
Simon Rozet February 24th, 2009 @ 05:03 PM
- Milestone cleared.
This need a bit more work. Moving to next milestone
-
Simon Rozet March 14th, 2009 @ 10:18 PM
From #113:
When I create a new project, the URL in the "edit" view of a project is incorrect and grabbing the host specified as my nginx upstream proxy: http://integrity-app-com/project... A relative URL path would be preferred as a permalink: /project_name
-
Josh Nichols March 18th, 2009 @ 05:30 PM
I came up with this monkey patch in config.ru, and it seems to do the trick for me:
-
ronin-278 (at lighthouseapp) March 21st, 2009 @ 11:52 PM
(from [7d4216991de80f64340f666fd18feb4782c3ab37]) Calculate URL using base_uri option instead of request.url
Hopefully this will fix URLs issues [#82] http://github.com/foca/integrity...
-
Simon Rozet March 22nd, 2009 @ 12:01 AM
- State changed from “open” to “resolved”
Please reopen if it is not fixed.
-
Simon Rozet March 22nd, 2009 @ 08:26 PM
- State changed from “resolved” to “open”
Looks like it is not, see will_l/integrity
-
Simon Rozet March 23rd, 2009 @ 07:49 PM
- Tag set to “url”
- State changed from “open” to “resolved”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Automated continuous integration server that doesn't suck.
People watching this ticket
Brad Gessler
Josh Nichols
Simon Rozet
Tags
Referenced by
-
113
Project permalinks are not relative URLs
Thanks for the report. We have several issues related to ...
-
82
Fix issues related to URL handling
Hopefully this will fix URLs issues [#82]
http://github....