#37 ✓wontfix
Simon Rozet

Better GitHub integration

Reported by Simon Rozet | November 9th, 2008 @ 02:42 PM

  • Link to commits
  • Link to project
  • Link to users

Comments and changes to this ticket

  • Simon Rozet

    Simon Rozet November 10th, 2008 @ 03:20 PM

    • Milestone cleared.
    • State changed from “new” to “open”
    • Assigned user set to “Simon Rozet”
  • Simon Rozet

    Simon Rozet November 11th, 2008 @ 09:44 PM

    • Milestone set to 0.1.9
  • Simon Rozet

    Simon Rozet November 16th, 2008 @ 07:07 PM

    see github branch

    I'm looking at the github stuff
    I don't like much how all the logic is spread across Build, Git, Git::Url
    maybe have an ExternalCodeRepository class (but with a better name =P), and have GitHub < ExternalCodeRepository
    we could then have project.external_code_repo, which goes over all the registered classes testing against each one, and returns the first one that returns true
    so GitHub.matches?(project) == true when project.uri.to_s =~ /github.com/
    and then that class holds all the logic -- like commit_url(build), commiter_url(build), project_url
    you could even go and implement classes like Gitorious, Unfuddle, GitWeb -- idk if it's a big advantage, but it would be possible
  • ronin-278 (at lighthouseapp)
  • Simon Rozet

    Simon Rozet March 15th, 2009 @ 01:35 AM

    • Milestone cleared.
    • Tag changed from git, github to after, git, github
    • State changed from “open” to “new”
    • Assigned user cleared.
  • Simon Rozet

    Simon Rozet October 26th, 2009 @ 06:10 PM

    • State changed from “new” to “wontfix”


Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Automated continuous integration server that doesn't suck.

Shared Ticket Bins

People watching this ticket