Send an email after building
Reported by ronin-278 (at lighthouseapp) | July 25th, 2008 @ 10:32 AM | in 0.1.9
Ok, so this is one of the most urgent things for 0.2 -- CI without getting notified is pretty worthless, since if you can "waste" time going to the website to see the result of the build you can just run it yourself.
So what I'm thinking: after on the Build, we dispatch a call to "all" the notifiers, passing the build object. So basically any class that supports SomeClass.notify_of_build(build) will be a notifier.
But, IMO, sending an email for each and every commit is excesive. So, for emails, I would only send them when the build "changed" status (either when it broke the project or when it fixed). But sending 8 consecutive mails because someone accidentally pushed without running the test suite is overkill.
I'm thinking if this "limitation" should be implemented on the notifiers or on the builder -- meaning, should the builder only tell the notifiers to send the report when the build changed status? Or should we leave it up to each notifier?
I like that the notifier only notifies and the decision is made by the builder, but maybe there's some horribly obvious reason why a notifier might want to always say "hey, you got a new build".
Thoughts?
Comments and changes to this ticket
-
Simon Rozet July 27th, 2008 @ 12:49 AM
I'm thinking if this "limitation" should be implemented on the
notifiers or on the builder -- meaning, should the builder only
tell the notifiers to send the report when the build changed
status? Or should we leave it up to each notifier?
IMO, the Builder should take care of knowing when notifiers should announce a new build. Notifier only takes a build struct and send it through mail, irc, campfire, msn, icq (nah, just kidding :P), post-card, whatever you have.
So again (huum, it is becoming a bit boring. we should desagree more!), I definitely agree, as well on the API.
-
Simon Rozet October 28th, 2008 @ 12:47 AM
- State changed from “new” to “resolved”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Automated continuous integration server that doesn't suck.
Simon Rozet