integrity_commits breaks b/c of null commit message
Reported by Jake Howerton | March 31st, 2009 @ 05:44 PM
http://github.com/foca/integrity...
The above commit breaks on sqlite, and probably everywhere?
project.rb:112:in find_or_create_commit_with_identifier'
tries to create a commit without a message. Stacktrace
below:
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/adapters/data_objects_adapter.rb:92:in
execute_non_query'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/adapters/data_objects_adapter.rb:92:inexecute'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/adapters/data_objects_adapter.rb:173:in
with_connection'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/adapters/data_objects_adapter.rb:90:inexecute'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/adapters/data_objects_adapter.rb:26:in
create'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/adapters/data_objects_adapter.rb:15:ineach'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/adapters/data_objects_adapter.rb:15:in
create'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/repository.rb:51:increate'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/resource.rb:589:in
hookable__create_nan_before_advised'
/usr/local/lib/ruby/gems/1.8/gems/extlib-0.9.11/lib/extlib/hook.rb:299:increate'
/usr/local/lib/ruby/gems/1.8/gems/extlib-0.9.11/lib/extlib/hook.rb:297:in
catch'
/usr/local/lib/ruby/gems/1.8/gems/extlib-0.9.11/lib/extlib/hook.rb:297:increate'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/resource.rb:295:in
hookable__save_nan_before_advised'
/usr/local/lib/ruby/gems/1.8/gems/extlib-0.9.11/lib/extlib/hook.rb:299:insave'
/usr/local/lib/ruby/gems/1.8/gems/extlib-0.9.11/lib/extlib/hook.rb:297:in
catch'
/usr/local/lib/ruby/gems/1.8/gems/extlib-0.9.11/lib/extlib/hook.rb:297:insave'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/model.rb:288:in
first_or_create'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/collection.rb:646:insend'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/collection.rb:646:in
method_missing'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/scope.rb:22:inwith_scope'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/scope.rb:32:in
with_exclusive_scope'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/scope.rb:22:inwith_scope'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/collection.rb:645:in
send'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/collection.rb:645:inmethod_missing'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/associations/one_to_many.rb:309:in
send'
/usr/local/lib/ruby/gems/1.8/gems/dm-core-0.9.11/lib/dm-core/associations/one_to_many.rb:309:inmethod_missing'
/usr/local/lib/ruby/gems/1.8/gems/foca-integrity-0.1.9.2/lib/integrity/project.rb:112:in
find_or_create_commit_with_identifier'
/usr/local/lib/ruby/gems/1.8/gems/foca-integrity-0.1.9.2/lib/integrity/project.rb:34:inbuild'
/usr/local/lib/ruby/gems/1.8/gems/foca-integrity-0.1.9.2/lib/integrity/app.rb:117:in
POST /:project/builds'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:696:incall'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:696:in
route'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:429:ininstance_eval'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:429:in
route!'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:426:incatch'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:426:in
route!'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:405:ineach'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:405:in
route!'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:497:indispatch!'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:350:in
call!'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:464:ininstance_eval'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:464:in
invoke'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:464:incatch'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:464:in
invoke'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:350:incall!'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:339:in
call'
/usr/local/lib/ruby/gems/1.8/gems/rack-0.9.1/lib/rack/methodoverride.rb:24:incall'
/usr/local/lib/ruby/gems/1.8/gems/rack-0.9.1/lib/rack/commonlogger.rb:20:in
_call'
/usr/local/lib/ruby/gems/1.8/gems/rack-0.9.1/lib/rack/commonlogger.rb:13:incall'
/usr/local/lib/ruby/gems/1.8/gems/rack-0.9.1/lib/rack/session/cookie.rb:35:in
call'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:796:incall'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:853:in
synchronize'
/usr/local/lib/ruby/gems/1.8/gems/sinatra-0.9.1.1/lib/sinatra/base.rb:794:incall'
/usr/local/lib/ruby/gems/1.8/gems/thin-1.0.0/lib/thin/connection.rb:63:in
pre_process'
/usr/local/lib/ruby/gems/1.8/gems/thin-1.0.0/lib/thin/connection.rb:54:inprocess'
/usr/local/lib/ruby/gems/1.8/gems/thin-1.0.0/lib/thin/connection.rb:39:in
receive_data'
/usr/local/lib/ruby/gems/1.8/gems/eventmachine-0.12.2/lib/eventmachine.rb:231:inrun_machine'
/usr/local/lib/ruby/gems/1.8/gems/eventmachine-0.12.2/lib/eventmachine.rb:231:in
run'
/usr/local/lib/ruby/gems/1.8/gems/thin-1.0.0/lib/thin/backends/base.rb:57:instart'
/usr/local/lib/ruby/gems/1.8/gems/thin-1.0.0/lib/thin/server.rb:150:in
start'
/usr/local/lib/ruby/gems/1.8/gems/thin-1.0.0/lib/thin/controllers/controller.rb:80:instart'
/usr/local/lib/ruby/gems/1.8/gems/thin-1.0.0/lib/thin/runner.rb:173:in
send'
/usr/local/lib/ruby/gems/1.8/gems/thin-1.0.0/lib/thin/runner.rb:173:inrun_command'
/usr/local/lib/ruby/gems/1.8/gems/thin-1.0.0/lib/thin/runner.rb:139:in
run!' /usr/local/lib/ruby/gems/1.8/gems/thin-1.0.0/bin/thin:6
/usr/local/bin/thin:19:inload' /usr/local/bin/thin:19
Comments and changes to this ticket
-
-
Craig Buchek April 2nd, 2009 @ 12:32 AM
I was able to work around this by editing foca-integrity-0.1.9.2/lib/integrity/project.rb to add to the commits.first_or_create() call on line 112:
:message => 'First commit.', :author => '(unknown) unknown@example.com',
Not sure if that makes sense, but I was able to get Integrity to work after that.
-
Simon Rozet April 4th, 2009 @ 06:30 PM
- Milestone cleared.
- Assigned user changed from “ronin-278 (at lighthouseapp)” to “Simon Rozet”
- State changed from “new” to “open”
-
ronin-278 (at lighthouseapp) April 5th, 2009 @ 05:11 PM
(from [1e116a04a6e9f4320a6e9c813fa05902e0348fc7]) Allow nil commit author and message
It should fix [#132]. http://github.com/foca/integrity...
-
Simon Rozet April 5th, 2009 @ 05:15 PM
- State changed from “open” to “resolved”
Please feel free to re-open if necessary
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
Automated continuous integration server that doesn't suck.
People watching this ticket
Jake Howerton
Simon Rozet
Attachments
Tags
Referenced by
-
132
integrity_commits breaks b/c of null commit message
It should fix [#132].
http://github.com/foca/integrity...