#95 ✓invalid
Simon Rozet

Update notifiers matchers/helpers

Reported by Simon Rozet | February 16th, 2009 @ 08:42 AM

Existing notifiers needs update too

Comments and changes to this ticket

  • Simon Rozet

    Simon Rozet February 19th, 2009 @ 04:58 PM

    • Assigned user cleared.
    • Tag changed from notifier to notifier, test

    How about an integrity-notifiers gems, same layout as Rack::Contrib? Keeping notifiers in one place would make it easier share test helpers (IMO, they shouldn't be managed in Integrity) and ensure they're all working.


  • ronin-278 (at lighthouseapp)

    ronin-278 (at lighthouseapp) February 19th, 2009 @ 05:06 PM

    That means installing a bunch of gems/dependencies that you don't want. For example, if all you want is email notifications, or IRC notifiactions, you don't want to install the basecamp gem, twitter gem, etc.

    I think that providing a NotifierTestHelpers module that notifiers can require in their tests is a bit more pragmatic, but if there's another alternative, I'm open to it :)

  • Simon Rozet

    Simon Rozet February 24th, 2009 @ 05:05 PM

    • Milestone cleared.

    Moving to 0.2. let's fix the email-notifiers first and extract matchers out of it after

  • Simon Rozet

    Simon Rozet March 15th, 2009 @ 01:27 AM

    • State changed from “new” to “invalid”
    • Assigned user set to “Simon Rozet”

    Duplicate with "Notifier Refactor" #104

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Automated continuous integration server that doesn't suck.

Shared Ticket Bins

People watching this ticket


Referenced by