Commit timezone support
Reported by Matt Gordon | May 2nd, 2009 @ 11:42 PM
I just finished getting GitHub callbacks to work, but it took me a little while to figure out it was working because the newer commits were never displayed as the current build, only in the 'previous builds' list. Some investigating revealed that at some point while I was working on it the timezone for the 'committed_at' field was changed from -4 to -7. Consequently, sorting by committed_at in the (sqlite) database gave the wrong commit as the current one.
It's possible this problem doesn't exist for other databases, which may take timezone into account when sorting.
Comments and changes to this ticket
-
Michael Moen June 1st, 2009 @ 03:02 AM
I think this may have been caused by the use of Time.new for the committed_at when requesting a manual build.
I have a patch that fetches the commit time from the repo and uses it.
I don't know if this covers all the possible times this could show up. It might be better to force committed_at to UTC whenever it is set.
-
Simon Rozet October 1st, 2009 @ 02:32 PM
- → Tag changed from “” to “dm”
This is a bug in DataMapper. http://datamapper.lighthouseapp.com/projects/20609/tickets/974-conv...
-
Simon Rozet October 1st, 2009 @ 09:28 PM
- → Title changed from “Normalize commit timezone to ensure build display order” to “Commit timezone support”
-
Simon Rozet October 21st, 2009 @ 08:18 PM
- → State changed from “new” to “moved”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Automated continuous integration server that doesn't suck.
